feat: add Vanio icon#476
Conversation
Greptile SummaryThis PR adds a new "Vanio" brand icon to the collection with
Confidence Score: 4/5Safe to merge after fixing the mono.svg fill color; the default and JSON entries look correct The mono variant has a hardcoded black fill that prevents CSS theming, which is how every other mono icon in the repo works. Merging as-is means the mono icon will always render black and ignore any dark-mode or custom-color context, which is a real behavioral regression relative to the rest of the collection. public/icons/vanio-informatika/mono.svg needs its fill corrected before merge
|
| Filename | Overview |
|---|---|
| public/icons/vanio-informatika/default.svg | New colored default/color SVG with viewBox and hardcoded brand colors; conventions are met for a color variant |
| public/icons/vanio-informatika/mono.svg | New mono SVG uses hardcoded fill="#000000" instead of fill="currentColor", breaking CSS theming unlike every other mono icon in the repo |
| src/data/icons.json | New "vanio" entry added; variant paths now correctly reference vanio-informatika folder; color variant reuses default.svg intentionally |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[icons.json entry\nslug: vanio] --> B[variant: default\n/icons/vanio-informatika/default.svg]
A --> C[variant: color\n/icons/vanio-informatika/default.svg]
A --> D[variant: mono\n/icons/vanio-informatika/mono.svg]
B --> E[default.svg\nfill=#65a0dc + fill=#ffffff\n✅ viewBox present]
C --> E
D --> F[mono.svg\nfill=#000000 ❌\nshould be fill=currentColor]
Reviews (3): Last reviewed commit: "feat: add Vanio icon" | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
Thanks for the contribution! Three small things before merge:
PR is on your fork's main branch so we can't push the fix from our side. Once those three are in we'll merge. |
|
Thanks @patoi for the Vanio Informatika contribution. Same note as #486: this branch is from your fork's main while our main has moved a couple hundred commits forward, so the PR currently reports ~140 file changes that are really just state your fork has not pulled in yet. Lint/Build and Validate SVG did not run. Could you rebase on the latest main with |
📝 WalkthroughWalkthroughA new brand icon entry for "vanio" is added to the icons data collection. The entry includes standard metadata: title, aliases, hex color code, categories, SVG variant references (default and mono), official URL, and publication date. ChangesIcon Data Update
Estimated Code Review Effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly Related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (2)
src/data/icons.json (2)
116946-116948:⚠️ Potential issue | 🟠 Major | ⚡ Quick winSlug and folder path mismatch.
The
slugis"vanio"but the variants paths reference/icons/vanio-informatika/. Per the coding guidelines,variantsobject keys must match filenames inpublic/icons/{slug}/.You must either:
- Rename the folder from
public/icons/vanio-informatika/topublic/icons/vanio/and update the paths here, OR- Change the slug from
"vanio"to"vanio-informatika"This issue was already flagged by reviewer
@thegdsksin the PR comments.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/data/icons.json` around lines 116946 - 116948, The variants' file paths reference "/icons/vanio-informatika/" while the entry's slug is "vanio", causing a mismatch; fix by making them consistent: either rename the slug value from "vanio" to "vanio-informatika" in the icons.json entry (update the "slug" field) so it matches the existing variant paths, or rename the icon folder to "vanio" and update the three variant paths ("default", "color", "mono") to use "/icons/vanio/"; ensure the slug string and all paths in the variants object match exactly.Source: Coding guidelines
116937-116953:⚠️ Potential issue | 🟠 Major | ⚡ Quick winEntry must be alphabetically sorted by slug.
The entry is appended at the end of the array, but the coding guidelines require entries to be alphabetically sorted by
slug. The "vanio" entry should be relocated to the v-prefixed section of the array, not at the end.This issue was already flagged by reviewer
@thegdsksin the PR comments.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/data/icons.json` around lines 116937 - 116953, The "vanio" entry (object with "slug": "vanio") is out of alphabetical order—move that entire object into the correct v-section of the icons array so entries remain sorted by slug; ensure you insert it among other slugs starting with "v", keep JSON syntax intact (commas, properties like "title","hex","variants","url","dateAdded","collection"), and run a quick sort-check of the array to confirm overall alphabetical ordering by slug.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/data/icons.json`:
- Around line 116937-116953: The entry with slug "vanio" (title "Vanio") is
missing the required license field; add a "license" property to this object
containing the license type and, if available, a URL (e.g., license: { "type":
"APPROPRIATE_LICENSE_TYPE", "url": "LICENSE_URL_IF_AVAILABLE" }) so the record
meets the icons.json schema; ensure you place it alongside the existing keys
(e.g., after "url" or before "dateAdded") and populate the actual license values
for the Vanio brand.
---
Duplicate comments:
In `@src/data/icons.json`:
- Around line 116946-116948: The variants' file paths reference
"/icons/vanio-informatika/" while the entry's slug is "vanio", causing a
mismatch; fix by making them consistent: either rename the slug value from
"vanio" to "vanio-informatika" in the icons.json entry (update the "slug" field)
so it matches the existing variant paths, or rename the icon folder to "vanio"
and update the three variant paths ("default", "color", "mono") to use
"/icons/vanio/"; ensure the slug string and all paths in the variants object
match exactly.
- Around line 116937-116953: The "vanio" entry (object with "slug": "vanio") is
out of alphabetical order—move that entire object into the correct v-section of
the icons array so entries remain sorted by slug; ensure you insert it among
other slugs starting with "v", keep JSON syntax intact (commas, properties like
"title","hex","variants","url","dateAdded","collection"), and run a quick
sort-check of the array to confirm overall alphabetical ordering by slug.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: ae91d8e6-771f-4047-80d6-2de5fb9e780b
⛔ Files ignored due to path filters (2)
public/icons/vanio-informatika/default.svgis excluded by!**/*.svgpublic/icons/vanio-informatika/mono.svgis excluded by!**/*.svg
📒 Files selected for processing (1)
src/data/icons.json
| { | ||
| "slug": "vanio", | ||
| "title": "Vanio", | ||
| "aliases": [], | ||
| "hex": "65A0DC", | ||
| "categories": [ | ||
| "Software" | ||
| ], | ||
| "variants": { | ||
| "default": "/icons/vanio-informatika/default.svg", | ||
| "color": "/icons/vanio-informatika/default.svg", | ||
| "mono": "/icons/vanio-informatika/mono.svg" | ||
| }, | ||
| "url": "https://vanio.hu", | ||
| "dateAdded": "2026-06-01", | ||
| "collection": "brands" | ||
| } |
There was a problem hiding this comment.
Missing required license field.
The coding guidelines specify that icons.json entries must include a license field, but it is absent from this entry. This is a required field that must be populated before merge.
📝 Add the missing license field
"variants": {
"default": "/icons/vanio-informatika/default.svg",
"color": "/icons/vanio-informatika/default.svg",
"mono": "/icons/vanio-informatika/mono.svg"
},
+ "license": {
+ "type": "APPROPRIATE_LICENSE_TYPE",
+ "url": "LICENSE_URL_IF_AVAILABLE"
+ },
"url": "https://vanio.hu",
"dateAdded": "2026-06-01",
"collection": "brands"Replace APPROPRIATE_LICENSE_TYPE and LICENSE_URL_IF_AVAILABLE with the actual license information for the Vanio brand icon.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| { | |
| "slug": "vanio", | |
| "title": "Vanio", | |
| "aliases": [], | |
| "hex": "65A0DC", | |
| "categories": [ | |
| "Software" | |
| ], | |
| "variants": { | |
| "default": "/icons/vanio-informatika/default.svg", | |
| "color": "/icons/vanio-informatika/default.svg", | |
| "mono": "/icons/vanio-informatika/mono.svg" | |
| }, | |
| "url": "https://vanio.hu", | |
| "dateAdded": "2026-06-01", | |
| "collection": "brands" | |
| } | |
| { | |
| "slug": "vanio", | |
| "title": "Vanio", | |
| "aliases": [], | |
| "hex": "65A0DC", | |
| "categories": [ | |
| "Software" | |
| ], | |
| "variants": { | |
| "default": "/icons/vanio-informatika/default.svg", | |
| "color": "/icons/vanio-informatika/default.svg", | |
| "mono": "/icons/vanio-informatika/mono.svg" | |
| }, | |
| "license": { | |
| "type": "APPROPRIATE_LICENSE_TYPE", | |
| "url": "LICENSE_URL_IF_AVAILABLE" | |
| }, | |
| "url": "https://vanio.hu", | |
| "dateAdded": "2026-06-01", | |
| "collection": "brands" | |
| } |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/data/icons.json` around lines 116937 - 116953, The entry with slug
"vanio" (title "Vanio") is missing the required license field; add a "license"
property to this object containing the license type and, if available, a URL
(e.g., license: { "type": "APPROPRIATE_LICENSE_TYPE", "url":
"LICENSE_URL_IF_AVAILABLE" }) so the record meets the icons.json schema; ensure
you place it alongside the existing keys (e.g., after "url" or before
"dateAdded") and populate the actual license values for the Vanio brand.
Source: Coding guidelines
2 participants
Description
Add new icon, Vanio Informatika
Type
Checklist
cd packages/icons && npm run buildnpm run auditnpm run validateFor icon submissions:
viewBoxattribute<script>tags or event handlersicons.jsonentry is complete (slug, title, hex, categories, variants)Related Issues
Summary by CodeRabbit